Skip to content

fix(google-cloud-serverless): Move @types/express to optional peerDeps #18452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JPeer264 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(google-cloud-serverless): Move @types/express to optional peerDeps #18452

JPeer264 wants to merge 2 commits into from
+49 −14

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Dec 10, 2025 •
edited
Loading

(closes #18438)
(closes JS-1273)

This moves the express types as optional peerDependencies. Since we are only relying on Request and Response and nothing more, this should be a save update. In order to also test against this - I updated the the local types to v5.

The pattern of having the types as optional peerDependencies is already given for our Cloudflare SDK:

sentry-javascript/packages/cloudflare/package.json

Lines 55 to 62 in 2ef3938

"peerDependencies": {
"@cloudflare/workers-types": "^4.x"
},
"peerDependenciesMeta": {
"@cloudflare/workers-types": {
"optional": true
}
},

@JPeer264 JPeer264 self-assigned this Dec 10, 2025
@linear
Copy link

linear bot commented Dec 10, 2025

JS-1273 Bump `@types/express` to v5 for `@sentry/google-cloud-serverless`

@JPeer264 JPeer264 marked this pull request as draft December 10, 2025 09:17
@JPeer264
Copy link
Member Author

JPeer264 commented Dec 10, 2025

(moved to draft because I don't want this to be merged yet (see #18438 (comment)), but it can be reviewed)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 11,218 - 8,936 +26%
GET With Sentry 1,921 17% 1,749 +10%
GET With Sentry (error only) 7,493 67% 6,262 +20%
POST Baseline 1,145 - 1,218 -6%
POST With Sentry 580 51% 609 -5%
POST With Sentry (error only) 1,005 88% 1,074 -6%
MYSQL Baseline 3,888 - 3,364 +16%
MYSQL With Sentry 473 12% 495 -4%
MYSQL With Sentry (error only) 3,125 80% 2,759 +13%

View base workflow run

@JPeer264 JPeer264 marked this pull request as ready for review December 15, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@timfish timfish Awaiting requested review from timfish

@Lms24 Lms24 Awaiting requested review from Lms24

@nicohrubec nicohrubec Awaiting requested review from nicohrubec

Assignees

@JPeer264 JPeer264

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump @types/express to v5 for @sentry/google-cloud-serverless

3 participants

@JPeer264 @AbhiPrasad